[libvirt] [PATCH] Add hw random number generator (/dev/hwrng) to default qemu cgroup ACL

[Daniel P. Berrange]

On Mon, Nov 18, 2013 at 06:58:06PM +0530, Pradipta Kr. Banerjee wrote:
> Creating a qemu VM with /dev/hwrng as backed RNG device throws the
> following error - "Could not open '/dev/hwrng': Operation not permitted"
> This patch fixes the issue
> 
> Signed-off-by: Pradipta Kr. Banerjee <bpradip at in.ibm.com>
> ---
>  src/qemu/qemu_cgroup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
> index ace7e35..d9ebb30 100644
> --- a/src/qemu/qemu_cgroup.c
> +++ b/src/qemu/qemu_cgroup.c
> @@ -39,7 +39,7 @@
>  
>  static const char *const defaultDeviceACL[] = {
>      "/dev/null", "/dev/full", "/dev/zero",
> -    "/dev/random", "/dev/urandom",
> +    "/dev/random", "/dev/urandom", "/dev/hwrng",
>      "/dev/ptmx", "/dev/kvm", "/dev/kqemu",
>      "/dev/rtc", "/dev/hpet", "/dev/vfio/vfio",
>      NULL,

NACK, for any device listed in the XML, we should add it in the per-VM
cgroups setup code.

The existing /dev/random & /dev/urandom devices are there because they
are used for basic crypto libraries unrelated to the XML config. The
/dev/hwrng device does not fall into this scenario.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|