[libvirt] [PATCH] qemuMonitorJSONGetCPUx86Data: Don't fail on ancient qemus

Eric Blake eblake at redhat.com
Tue Nov 19 14:53:12 UTC 2013


On 11/19/2013 07:44 AM, Michal Privoznik wrote:
> On the domain startup, this function is called to dump some info about
> the CPUs. At the beginning of the function we check if we aren't running
> older qemu which is not exposing the CPUs via 'qom-list'. However, we
> are not checking for even older qemus, which throw 'CommandNotFound'
> error.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_monitor_json.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)

Any chance we can enhance the testsuite to cover this?  At any rate, ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131119/21cbc76b/attachment-0001.sig>


More information about the libvir-list mailing list