[libvirt] [PATCH] python: add virConnectGetCPUModelNames to skip_impl

[Doug Goldstein]

On Tue, Nov 19, 2013 at 4:17 PM, Doug Goldstein <cardoe at cardoe.com> wrote:
> In commit de51dc9c9, we removed virConnectGetCPUModelNames from
> skip_impl but without this the module will always generate a symbol for
> libvirt_virConnectGetCPUModelNames which we don't always want.
>
>     CC: Giuseppe Scrivano <gscrivan at redhat.com>
> ---
> I don't really understand the generator enough to know why this was
> removed but without this change the module will always generate the
> symbol. Maybe someone more knowledgable with the code can explain?
> I've CC'd the original author as well.
> ---
>  python/generator.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/python/generator.py b/python/generator.py
> index 87ecf5a..99bf965 100755
> --- a/python/generator.py
> +++ b/python/generator.py
> @@ -450,6 +450,7 @@ skip_impl = (
>      'virNodeGetCPUMap',
>      'virDomainMigrate3',
>      'virDomainMigrateToURI3',
> +    'virConnectGetCPUModelNames',
>  )
>
>  lxc_skip_impl = (
> --
> 1.8.3.2
>

I'm going to personally NACK my own patch. It looks like another
change will have to be made at the same time. The API is appearing as
libvirt.getCPUModelNames() instead of
libvirt.virConnect.getCPUModelNames() with this change due to some
other code that's moving it. So I'll just fix both issues in 1 commit.

-- 
Doug Goldstein