[libvirt] [PATCH 03/18] qemuMonitorJSONSendKey: Avoid double free

Michal Privoznik mprivozn at redhat.com
Wed Oct 2 17:09:52 UTC 2013


After successful @cmd construction the memory where @keys points to is
part of @cmd. Avoid double freeing it.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/qemu/qemu_monitor_json.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index fc57c00..cd6cb72 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
@@ -3452,6 +3452,9 @@ int qemuMonitorJSONSendKey(qemuMonitorPtr mon,
     if (!cmd)
         goto cleanup;
 
+    /* @keys is part of @cmd now. Avoid double free */
+    keys = NULL;
+
     if ((ret = qemuMonitorJSONCommand(mon, cmd, &reply)) < 0)
         goto cleanup;
 
-- 
1.8.1.5




More information about the libvir-list mailing list