[libvirt] [PATCH] build: fix 'make -C src check' under subset builds

[Eric Blake]

On 09/27/2013 07:32 AM, Eric Blake wrote:
> Another build failure detected on cygwin, where lxc is not built.
> The lxc_monitor_protocol.c file requires the use of $(XDR_CFLAGS),
> but should only be built on platforms where WITH_LXC is true;
> however, 'make -C src check' was unconditionally trying to build
> the .o file (and with the wrong CFLAGS) in order to validate the
> matching -structs file.  Rework the checks to only test files that
> are built for the current configuration.
> 
> * src/Makefile.am (PROTOCOL_STRUCTS): Split list by which files
> are currently being compiled.
> (EXTRA_DIST): Ensure that -structs files are shipped even when not
> built.
> (check-protocol): Declare unconditionally, now that the condition
> has been moved into PROTOCOL_STRUCTS.
> (libvirt_driver_lxc_impl_la_CFLAGS): Add $(XDR_CFLAGS).
> (libvirt_net_rpc_la_SOURCES): List generated files more compactly.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
> 
> This is a build-breaker, but I'm still in the middle of running
> a (lengthy) 'make distcheck' on several platforms before pushing,
> so a review wouldn't hurt.

I found other issues with 'make distcheck' [1] that have to be fixed
first, so I postponed this patch and it did not make 1.1.3.  As a
result, I'm still waiting for a review.

[1] https://www.redhat.com/archives/libvir-list/2013-October/msg00172.html

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131003/3cccf8e5/attachment-0001.sig>