[libvirt] [PATCH 00/15] fix misuse of 'const fooPtr'

Eric Blake eblake at redhat.com
Tue Oct 8 17:24:57 UTC 2013


Mostly cleanup, but at least one bug fix (xen was instantiating
a memballoon device too early, during the post-parse callback
of the first device rather than after all devices were known).

Spawned by the conversation here:
https://www.redhat.com/archives/libvir-list/2013-September/thread.html#01311

Eric Blake (15):
  maint: avoid 'const fooPtr' in public API
  maint: avoid 'const fooPtr' in hashes
  maint: avoid 'const fooPtr' in several util files
  maint: avoid 'const fooPtr' in virnet files
  maint: avoid 'const fooPtr' in cpu files
  maint: avoid 'const fooPtr' in nwfilter files
  maint: avoid 'const fooPtr' in tests
  maint: avoid 'const fooPtr' in python bindings
  maint: fix awkward typing of virDomainChrGetDomainPtrs
  maint: avoid 'const fooPtr' in domain_conf
  maint: avoid 'const fooPtr' in conf
  maint: avoid 'const fooPtr' in security
  maint: avoid 'const fooPtr' in qemu
  maint: avoid 'const fooPtr' in all remaining places
  build: syntax check to avoid 'const fooPtr'

 cfg.mk                                    |   8 ++
 include/libvirt/libvirt.h.in              |   6 +-
 python/generator.py                       |  11 --
 python/libvirt-override.c                 |   4 +-
 src/conf/cpu_conf.c                       |   6 +-
 src/conf/cpu_conf.h                       |   8 +-
 src/conf/domain_conf.c                    | 164 ++++++++++++++++++------------
 src/conf/domain_conf.h                    |  33 +++---
 src/conf/interface_conf.c                 |  30 +++---
 src/conf/interface_conf.h                 |  15 ++-
 src/conf/netdev_vlan_conf.c               |   4 +-
 src/conf/netdev_vlan_conf.h               |   4 +-
 src/conf/network_conf.c                   |  44 ++++----
 src/conf/network_conf.h                   |  28 ++---
 src/conf/node_device_conf.c               |  14 +--
 src/conf/node_device_conf.h               |  14 +--
 src/conf/nwfilter_conf.c                  |   6 +-
 src/conf/nwfilter_conf.h                  |   8 +-
 src/conf/nwfilter_params.c                |  52 +++++-----
 src/conf/nwfilter_params.h                |  32 +++---
 src/conf/secret_conf.c                    |   8 +-
 src/conf/secret_conf.h                    |   4 +-
 src/conf/snapshot_conf.c                  |   6 +-
 src/conf/snapshot_conf.h                  |   6 +-
 src/cpu/cpu.c                             |   8 +-
 src/cpu/cpu.h                             |  16 +--
 src/cpu/cpu_arm.c                         |   3 +-
 src/cpu/cpu_powerpc.c                     |   9 +-
 src/cpu/cpu_s390.c                        |   3 +-
 src/cpu/cpu_x86.c                         |  18 ++--
 src/libxl/libxl_domain.c                  |   2 +-
 src/lxc/lxc_domain.c                      |   4 +-
 src/lxc/lxc_process.c                     |   4 +-
 src/nwfilter/nwfilter_dhcpsnoop.c         |  12 +--
 src/nwfilter/nwfilter_dhcpsnoop.h         |   3 +-
 src/nwfilter/nwfilter_ebiptables_driver.c |  18 ++--
 src/nwfilter/nwfilter_gentech_driver.c    |  23 +++--
 src/nwfilter/nwfilter_gentech_driver.h    |  11 +-
 src/nwfilter/nwfilter_learnipaddr.c       |   9 +-
 src/nwfilter/nwfilter_learnipaddr.h       |   4 +-
 src/openvz/openvz_driver.c                |   2 +-
 src/qemu/qemu_bridge_filter.c             |  10 +-
 src/qemu/qemu_bridge_filter.h             |  10 +-
 src/qemu/qemu_command.c                   |  34 +++----
 src/qemu/qemu_conf.c                      |   2 +-
 src/qemu/qemu_domain.c                    |   5 +-
 src/qemu/qemu_driver.c                    |   2 +-
 src/qemu/qemu_hostdev.c                   |   2 +-
 src/qemu/qemu_monitor_json.c              |   2 +-
 src/security/security_apparmor.c          |  22 ++--
 src/security/security_selinux.c           |   2 +-
 src/uml/uml_driver.c                      |  15 +--
 src/util/virbuffer.c                      |   8 +-
 src/util/virbuffer.h                      |   8 +-
 src/util/virebtables.c                    |   4 +-
 src/util/virebtables.h                    |   6 +-
 src/util/virhash.c                        |  21 ++--
 src/util/virhash.h                        |  19 ++--
 src/util/virmacaddr.c                     |  16 +--
 src/util/virmacaddr.h                     |  16 +--
 src/util/virnetdev.c                      |  20 ++--
 src/util/virnetdev.h                      |   8 +-
 src/util/virnetdevbandwidth.c             |   6 +-
 src/util/virnetdevbandwidth.h             |   7 +-
 src/util/virnetdevmacvlan.c               |  22 ++--
 src/util/virnetdevmacvlan.h               |  12 +--
 src/util/virnetdevopenvswitch.c           |   3 +-
 src/util/virnetdevopenvswitch.h           |   3 +-
 src/util/virnetdevtap.c                   |   2 +-
 src/util/virnetdevtap.h                   |   4 +-
 src/util/virnetdevvlan.c                  |   6 +-
 src/util/virnetdevvlan.h                  |   6 +-
 src/util/virnetdevvportprofile.c          |  28 ++---
 src/util/virnetdevvportprofile.h          |  10 +-
 src/util/virnetlink.c                     |  10 +-
 src/util/virnetlink.h                     |   8 +-
 src/util/virsocketaddr.c                  |  54 +++++-----
 src/util/virsocketaddr.h                  |  52 +++++-----
 src/xen/xen_driver.c                      |  12 ++-
 src/xen/xm_internal.c                     |   4 +-
 tests/cputest.c                           |   4 +-
 tests/qemucapabilitiestest.c              |   2 +-
 tests/qemumonitorjsontest.c               |  21 ++--
 tests/virhashtest.c                       |   8 +-
 84 files changed, 625 insertions(+), 555 deletions(-)

-- 
1.8.3.1




More information about the libvir-list mailing list