[libvirt] [PATCH] esx: Fix floppy.fileName handling in the vmx file parser
Eric Blake
eblake at redhat.com
Thu Oct 10 23:07:57 UTC 2013
On 10/10/2013 02:49 PM, Geoff Hickey wrote:
> Eric: No problem, I'll resubmit with git (sorry about that, it's been long
> enough since my last submit that I forgot about that), but I'll fix the
> issue that Doug pointed out first. As for the pointer comparison to NULL,
> I'm in complete agreement, but that particular source file uses the != NULL
> idiom everywhere. I'd be happy to remove it everywhere, but that should be
> done as a separate submit, I would think?
Indeed, if you're going to clean up the entire file, do it as a separate
commit.
>
> Thanks, 2nd try soon. :)
Looking forward to it.
Also, we tend to avoid top-posting on this list.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131010/617b4d2d/attachment-0001.sig>
More information about the libvir-list
mailing list