[libvirt] [PATCH 07/15] maint: avoid 'const fooPtr' in tests
Daniel P. Berrange
berrange at redhat.com
Mon Oct 14 15:29:51 UTC 2013
On Tue, Oct 08, 2013 at 11:25:04AM -0600, Eric Blake wrote:
> 'const fooPtr' is the same as 'foo * const' (the pointer won't
> change, but it's contents can). But in general, if an interface
> is trying to be const-correct, it should be using 'const foo *'
> (the pointer is to data that can't be changed).
>
> Fix up offenders in the testsuite.
>
> * tests/cputest.c (cpuTestCompareXML): Use intended type.
> * tests/qemucapabilitiestest.c (testQemuCaps): Likewise.
> * tests/qemumonitorjsontest.c: Drop const.
>
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
> tests/cputest.c | 4 ++--
> tests/qemucapabilitiestest.c | 2 +-
> tests/qemumonitorjsontest.c | 21 +++++++++++----------
> 3 files changed, 14 insertions(+), 13 deletions(-)
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list