[libvirt] [PATCHv2 02/23] conf: Clean up few error messages

Daniel P. Berrange berrange at redhat.com
Tue Oct 15 12:41:50 UTC 2013


On Tue, Oct 15, 2013 at 02:30:31PM +0200, Peter Krempa wrote:

Nice to mention what file /  method is being changed.

> ---
>  src/conf/domain_conf.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 6bf2b30..365de77 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -11408,8 +11408,7 @@ virDomainDefParseXML(xmlDocPtr xml,
>          int val = virDomainFeatureTypeFromString((const char *)nodes[i]->name);
>          if (val < 0) {
>              virReportError(VIR_ERR_INTERNAL_ERROR,
> -                           _("unexpected feature %s"),
> -                           nodes[i]->name);
> +                           _("unexpected feature '%s'"), nodes[i]->name);
>              goto error;
>          }
>          def->features |= (1 << val);
> @@ -11419,7 +11418,7 @@ virDomainDefParseXML(xmlDocPtr xml,
>                  int eoi;
>                  if ((eoi = virDomainFeatureStateTypeFromString(tmp)) <= 0) {
>                      virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
> -                                   _("unknown value for attribute eoi: %s"),
> +                                   _("unknown value for attribute eoi: '%s'"),
>                                     tmp);
>                      goto error;
>                  }

ACK if expanding the commit message.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list