[libvirt] build: fix linking virt-login-shell

Jim Fehlig jfehlig at suse.com
Mon Oct 21 21:36:11 UTC 2013


After commit 3e2f27e1, I've noticed build failures of virt-login-shell
when libapparmor-devel is installed on the build host

CCLD     virt-login-shell
../src/.libs/libvirt-setuid-rpc-client.a(libvirt_setuid_rpc_client_la-vircommand.o):
In function `virExec':
/home/jfehlig/virt/upstream/libvirt/src/util/vircommand.c:653: undefined
reference to `aa_change_profile'
collect2: error: ld returned 1 exit status

I was about to commit an easy fix under the build-breaker rule
(build-fix-1.patch), but thought to extend the notion of SECDRIVER_LIBS
to SECDRIVER_CFLAGS, and use both throughout src/Makefile.am where it
makes sense (build-fix-2.patch).

Should I just stick with the simple fix, or is something along the lines
of patch 2 preferred?

Regards,
Jim



-------------- next part --------------
A non-text attachment was scrubbed...
Name: build-fix-1.patch
Type: text/x-patch
Size: 1398 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131021/c2ef6d6f/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build-fix-2.patch
Type: text/x-patch
Size: 2569 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131021/c2ef6d6f/attachment-0003.bin>


More information about the libvir-list mailing list