[libvirt] [PATCH]lxc: improve readability of lxcContainer[Send|Waitfor]Continue

Martin Kletzander mkletzan at redhat.com
Thu Oct 24 10:51:37 UTC 2013


On Thu, Oct 24, 2013 at 05:55:59PM +0800, Chen Hanxiao wrote:
> 
> 
> > > Subject: Re: [libvirt] [PATCH]lxc: improve readability of
> > > lxcContainer[Send|Waitfor]Continue
> > >
> > > On 16.10.2013 08:27, Chen Hanxiao wrote:
> > > > From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> > >
> > > I think this can be achieved even without this hack. We already can
> > > produce a stack trace on VIR_DEBUG() [1]. And if you don't want to keep
> > > only some debug messages, apply filters.
> > >
> > 
> > If we only config debug option for output values, we got:
> > 604+0000: 12010: debug : lxcContainerWaitForContinue:392 : Wait continue
> on
> > fd 21
> > 
> > If we config filter option as "1:+lxc", we got:
> > 2013-10-22 02:24:30.365+0000: 13579: debug :
> > lxcContainerWaitForContinue:392
> > : Wait continue on fd 12
> > /usr/libexec/libvirt_lxc(virLogMessage+0x97)[0x7f2e1bdfa387]
> > /usr/libexec/libvirt_lxc(lxcContainerWaitForContinue+0x4b)[0x7f2e1bd7346b]
> > /usr/libexec/libvirt_lxc(+0x3197b)[0x7f2e1bd7b97b]
> > /usr/libexec/libvirt_lxc(main+0xcdf)[0x7f2e1bd70e4f]
> > /lib64/libc.so.6(__libc_start_main+0xf5)[0x7f2e19761b75]
> > /usr/libexec/libvirt_lxc(+0x27065)[0x7f2e1bd71065]
> > 

You can convert those using addr2line.

> > We still can't see who is the caller, and we got too many logs.
> > Additionally, filters with long name like ' lxcContainerWaitForContinue'
> > will not take effect.
> > 
> > With this patch, we got:
> > 17931: debug : lxcContainerWaitForContinue:394 : virLXCControllerRun wait
> > continue on fd 12
> > 
> > I think we still need this patch.
> > 

I don't, though.  This adds unnecessary code.

Sorry,
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131024/5c8bc3d6/attachment-0001.sig>


More information about the libvir-list mailing list