[libvirt] [PATCH 1/2 v2]virsh: introduce member excludeOption in vshCmdOptDef and improve auto complete with it

[Eric Blake]

On 10/28/2013 10:08 PM, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> 
> If we need to exclude one parameters from another,
> we could use this member to specify one.
> 
> With this flag, we could archive what Eric comment on:
> https://www.redhat.com/archives/libvir-list/2013-October/msg00965.html
> 1. COMMAND <TAB> or COMMAND --<TAB>
> Auto complete will NOT show option that marked as VSH_OT_ALIAS
> 2. COMMAND --sh<TAB>
> Auto complete will show --shareable
> (this one was marked as VSH_OT_ALIAS)
> 3. COMMAND --mode XXX <TAB> or COMMAND --mode XXX --sh<TAB>
> Auto complete will NOT show --shareable
> (we set new member exclude_option for mode)
> 4. COMMAND --shareable --mo<TAB>
> Auto complete will NOT show --mode
> (we set new member exclude_option for mode)
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> ---
> v2:
> use camelCase for struct members
> enable excludeOption to hold more than one options by
> a comma seperated string.

I'm not sure we need this patch.  Tab completion already needs to be
improved for other reasons, and adding this patch just for the sake of
patch 2/2, which I already said is probably not necessary, seems like it
would just be churn for Tomas' work on overall improvements.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131029/4ccf5ea9/attachment-0001.sig>