[libvirt] [PATCH] Fix leak of objects when reconnecting to QEMU instances

Eric Blake eblake at redhat.com
Tue Oct 29 14:04:40 UTC 2013


On 10/29/2013 07:59 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> The 'error' cleanup block in qemuProcessReconnect() had a
> 'return' statement in the middle of it. This caused a leak
> of virConnectPtr & virQEMUDriverConfigPtr instances. This
> was identified because netcf recently started checking its
> refcount in libvirtd shutdown:
> 
> netcfStateCleanup:109 : internal error: Attempt to close netcf state driver with open connections
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  src/qemu/qemu_process.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

ACK; worth having in 1.1.4.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 621 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20131029/fa73e344/attachment-0001.sig>


More information about the libvir-list mailing list