[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 8/8] qemu: Support virtio-mmio transport for virtio on ARM



On Fri, Aug 30, 2013 at 12:41:36PM -0400, Cole Robinson wrote:
> Starting with qemu 1.6, the qemu-system-arm vexpress-a9 model has a
> hardcoded virtio-mmio transport which enables attaching all virtio
> devices.
> 
> On the command line, we have to use virtio-XXX-device rather than
> virtio-XXX-pci, thankfully s390 already set the precedent here so
> it's fairly straight forward.
> 
> At the XML level, this adds a new device address type virtio-mmio.
> The controller and addressing don't have any subelements at the
> moment because we they aren't needed for this usecase, but could
> be added later if needed.
> 
> Add a test case for an ARM guest with one of every virtio device
> enabled.
> ---
>  src/conf/domain_conf.c                             | 12 +++-
>  src/conf/domain_conf.h                             |  1 +
>  src/qemu/qemu_capabilities.c                       | 17 ++++--
>  src/qemu/qemu_capabilities.h                       |  2 +
>  src/qemu/qemu_command.c                            | 65 +++++++++++++++++-----
>  .../qemuxml2argv-arm-vexpressa9-virtio.args        | 14 +++++
>  .../qemuxml2argv-arm-vexpressa9-virtio.xml         | 45 +++++++++++++++
>  tests/qemuxml2argvtest.c                           |  4 ++
>  8 files changed, 139 insertions(+), 21 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-arm-vexpressa9-virtio.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-arm-vexpressa9-virtio.xml

ACK


> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> index 380e2bb..1d70eba 100644
> --- a/src/conf/domain_conf.h
> +++ b/src/conf/domain_conf.h
> @@ -207,6 +207,7 @@ enum virDomainDeviceAddressType {
>      VIR_DOMAIN_DEVICE_ADDRESS_TYPE_SPAPRVIO,
>      VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_S390,
>      VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW,
> +    VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_MMIO,
>  
>      VIR_DOMAIN_DEVICE_ADDRESS_TYPE_LAST
>  };

So there's no kind of address properties needed for the MMIO
address type ?


ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]