[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCHv2 RESEND 0/5] Handling of undefine and redefine snapshots with VirtualBox 4.2



Hi,
This is a serie of patches in order to support undefining and redefining
snapshots with VirtualBox 4.2.

The serie of patches is rather big, and adds among other things some utility functions unrelated to VirtualBox in patches 1 & 2.
The code review could be done in several parts: e.g. patches 1 & 2 separately to validate the utility functions.

This 2nd version brings a different function for string replacement, because of the license problem with
the first one.

The VirtualBox API provides only high level operations to manipulate snapshots,
so it not possible to support flags like VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE and
VIR_DOMAIN_SNAPSHOT_DELETE_METADATA_ONLY with only API calls.
Following an IRC talk with Eric Blake, the decision was taken to emulate these
behaviours by manipulating directly the .vbox XML files.

The first two patches are some util methods for handling uuid and strings that
will be used after.

The third patch brings more details in the snapshot XML returned by libvirt.
We will need those modifications in order to redefine the snapshots.

The fourth patch brings the support of the VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE
and VIR_DOMAIN_SNAPSHOT_CREATE_CURRENT flags in virDomainSnapshotCreateXML.

The fifth and last patch brings the support of the VIR_DOMAIN_SNAPSHOT_DELETE_METADATA_ONLY
flag in virDomainSnapshotDelete.

The patches are only for Virtualbox 4.2

Regards,
Manuel VIVES


Manuel VIVES (5):
  viruuid.h/c: Util method for finding uuid patterns in some strings
  virstring.h/c: Util method for making some find and replace in
    strings
  vbox_tmpl.c: Better XML description for snapshots
  vbox_tmpl.c: Patch for redefining snapshots
  vbox_tmpl.c: Add methods for undefining snapshots

 src/conf/domain_conf.c   |   20 +-
 src/libvirt_private.syms |    2 +
 src/util/virstring.c     |   48 ++
 src/util/virstring.h     |    2 +
 src/util/viruuid.c       |   79 ++
 src/util/viruuid.h       |    1 +
 src/vbox/vbox_tmpl.c     | 1846 +++++++++++++++++++++++++++++++++++++++++++---
 7 files changed, 1878 insertions(+), 120 deletions(-)

-- 
1.7.10.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]