[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 4/4] VMX: Some serial ports are not actually connected



On Thu, Aug 29, 2013 at 5:19 AM, Michal Privoznik <mprivozn redhat com> wrote:
On 28.08.2013 23:53, Doug Goldstein wrote:
> Sometimes a serial port might not be actually wired to a device when the
> user does not have the VM powered on and we should not consider this a
> fatal error.
> ---
>  src/vmx/vmx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c
> index bcbb997..036e234 100644
> --- a/src/vmx/vmx.c
> +++ b/src/vmx/vmx.c
> @@ -2702,7 +2702,7 @@ virVMXParseSerial(virVMXContext *ctx, virConfPtr conf, int port,
>
>      /* vmx:fileName -> def:data.file.path */
>      if (virVMXGetConfigString(conf, fileName_name, &fileName, false) < 0) {
> -        goto cleanup;
> +        goto ignore;
>      }
>
>      /* vmx:network.endPoint -> def:data.tcp.listen */
>

ACK

Michal

Pushed. thanks.


--
Doug Goldstein

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]