[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] virsh-domain: Avoid killing ssh transport tunnels when cancelling job



On 09/03/13 09:53, Michal Privoznik wrote:
> On 29.08.2013 17:52, Peter Krempa wrote:
>> The vshWatchJob function registers a SIGINT handler that is used to
>> abort the active job and does not terminate virsh. Unfortunately, this
>> breaks when using the ssh transport as SIGINT is sent to the foreground
>> process group including the ssh transport processes which terminate.
>> This breaks the connection and migration is left in a insane state.
>>
>> With this patch the terminal is modified to ignore key binding that
>> sends SIGINT and does the handling manually.
>>
>> Resoves: https://bugzilla.redhat.com/show_bug.cgi?id=983348
>> ---
>>  tools/virsh-domain.c | 45 ++++++++++++++++++++++++++++++++-------------
>>  1 file changed, 32 insertions(+), 13 deletions(-)
>>
> 
> ACK
> 
> Michal
> 

Thanks for the reviews, I've pushed 2/3 and 3/3 now.

Peter


Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]