[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/3] Fix and clean up multiple issues in virsh console handling



On 29.08.2013 18:36, Peter Krempa wrote:
> This series has to be applied on top of "virsh: Handle interrupting of jobs manually".
> 
> Peter Krempa (3):
>   tools: rename console.[ch] to virsh-console.[ch] and fix coding style
>   virsh: Rename vshMakeStdinRaw to vshTTYMakeRaw and move it to virsh.c
>   virsh-console: Avoid using signal() in multithreaded application
> 
>  cfg.mk                               |   2 +-
>  po/POTFILES.in                       |   2 +-
>  tools/Makefile.am                    |   2 +-
>  tools/{console.c => virsh-console.c} | 153 +++++++++++++++--------------------
>  tools/{console.h => virsh-console.h} |  11 ++-
>  tools/virsh-domain.c                 |   4 +-
>  tools/virsh.c                        |  50 +++++++++++-
>  tools/virsh.h                        |   1 +
>  8 files changed, 123 insertions(+), 102 deletions(-)
>  rename tools/{console.c => virsh-console.c} (76%)
>  rename tools/{console.h => virsh-console.h} (81%)
> 


ACK series, but see my comments to 1/3.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]