[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] spec: Only distribute ChangeLog in -devel package



On Wed, Sep 04, 2013 at 10:24:06AM -0400, Cole Robinson wrote:
> Helps save space on the Fedora livecd, as requested here:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=977099
> ---
>  libvirt.spec.in | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index e94901a..a327eab 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -1739,7 +1739,6 @@ fi
>  %files daemon
>  %defattr(-, root, root)
>  
> -%doc AUTHORS ChangeLog.gz NEWS README COPYING COPYING.LESSER TODO
>  %dir %attr(0700, root, root) %{_sysconfdir}/libvirt/
>  
>      %if %{with_network}
> @@ -2011,7 +2010,6 @@ fi
>  
>  %files client -f %{name}.lang
>  %defattr(-, root, root)
> -%doc AUTHORS ChangeLog.gz NEWS README COPYING COPYING.LESSER TODO
>  
>  %config(noreplace) %{_sysconfdir}/libvirt/libvirt.conf
>  %config(noreplace) %{_sysconfdir}/libvirt/virt-login-shell.conf
> @@ -2081,6 +2079,7 @@ fi
>  %{_datadir}/libvirt/api/libvirt-qemu-api.xml
>  %{_datadir}/libvirt/api/libvirt-lxc-api.xml
>  
> +%doc AUTHORS ChangeLog.gz NEWS README COPYING COPYING.LESSER TODO
>  %doc docs/*.html docs/html docs/*.gif
>  %doc docs/libvirt-api.xml
>  %doc examples/hellolibvirt

The subject says you're moving the ChangeLog file, but you're in fact
moving all docs files. I don't think it is right to move the COPYING
and COPYING.LESSER files - I think those should say in libvirt-client
so that they're always present for any possible libvirt sub-RPM install.

In fact I believe this is required by packaging guidelines

  https://fedoraproject.org/wiki/Packaging:LicensingGuidelines

 [quote]
 Subpackage Licensing

 If a subpackage is dependent (either implicitly or explicitly)
 upon a base package (where a base package is defined as a 
 resulting binary package from the same source RPM which contains
 the appropriate license texts as %doc), it is not necessary for
 that subpackage to also include those license texts as %doc.

 However, if a subpackage is independent of any base package (it
 does not require it, either implicitly or explicitly), it must
 include copies of any license texts (as present in the source)
 which are applicable to the files contained within the subpackage. 
 [/quote]



Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]