[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] virsh: Rename vshMakeStdinRaw to vshTTYMakeRaw and move it to virsh.c



On 08/29/2013 10:36 AM, Peter Krempa wrote:
> Move the function to virsh.c to the rest of the TTY managing functions
> and change the code so that it mirrors the rest.
> ---
>  tools/virsh-console.c | 50 +++++---------------------------------------------
>  tools/virsh-console.h |  7 +++----
>  tools/virsh-domain.c  |  2 +-
>  tools/virsh.c         | 48 +++++++++++++++++++++++++++++++++++++++++++++---
>  tools/virsh.h         |  1 +
>  5 files changed, 55 insertions(+), 53 deletions(-)

As we guessed on IRC, this and similar patches have broken the build for
mingw, which lacks most terminal control functions.  I'm working on a
patch that uses #ifndef WIN32 to skip the code that doesn't work on
mingw (I don't know if mingw can ever reliably use ssh connections, or
if it is better off relying on tls certificates for authentication instead).

In file included from ../../tools/virsh-domain-monitor.h:29:0,
                 from ../../tools/virsh-domain-monitor.c:27:
../../tools/virsh.h:245:20: error: field 'termattr' has incomplete type
     struct termios termattr;    /* settings of the tty terminal */
                    ^
In file included from ../../tools/virsh-host.h:29:0,
                 from ../../tools/virsh-host.c:27:
...

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]