[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] libxl: Unconditionally call virSysinfoRead() on driver init



On 09/04/2013 05:07 PM, Jim Fehlig wrote:
> No need to check if priviledged when reading hostsysinfo, since
> that check was already done in libxlDriverShouldLoad().  The
> libxl driver fails to load if not priviledged.

s/priviledged/privileged/ (twice)

> 
> Signed-off-by: Jim Fehlig <jfehlig suse com>
> ---
>  src/libxl/libxl_driver.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

ACK.

> 
> diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
> index 426167c..e2a6d44 100644
> --- a/src/libxl/libxl_driver.c
> +++ b/src/libxl/libxl_driver.c
> @@ -873,8 +873,7 @@ libxlStateInitialize(bool privileged,
>      }
>  
>      /* read the host sysinfo */
> -    if (privileged)
> -        libxl_driver->hostsysinfo = virSysinfoRead();
> +    libxl_driver->hostsysinfo = virSysinfoRead();
>  
>      libxl_driver->domainEventState = virDomainEventStateNew();
>      if (!libxl_driver->domainEventState)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]