[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: shut up automake warnings



On 09/05/2013 12:08 AM, Martin Kletzander wrote:
> On Wed 04 Sep 2013 06:48:46 PM CEST, Eric Blake wrote:
>> I'm tired of seeing screenfuls of messages like these when using
>> automake 1.13 (Fedora 19):
>>
>> configure.ac:2121: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged.
>> configure.ac:2121: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead,
>> configure.ac:2121: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files.
>> daemon/Makefile.am:19: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
>>
> 
> These were driving me crazy, but I thought we had no other option than
> to leave this due to compatibility.  Thanks for finding the way out of this.
> 
> Unfortunately, 1.14 complains about subdir-objects way more than about
> anything else and I still haven't found the way out of that one.

Ouch - rawhide is currently still stuck on 1.13.4 [so much for the
perception of rawhide being bleeding-edge]; I'll have to manually
install from automake.git to play with subdir-objects (it may be easiest
to just unconditionally turn it on, after testing that RHEL 5's 1.9 can
handle it), as a followup patch.

>> -# Use the silent-rules feature when possible.
>> -m4_ifndef([AM_SILENT_RULES], [m4_define([AM_SILENT_RULES],[])])
>> -AM_SILENT_RULES([yes])
>> +# Default to using the silent-rules feature when possible.  Formatting
>> +# chosen to bypass 'grep' checks that cause older automake to warn.
>> +# Users (include rpm) can still change the default at configure time.
>> +m4_ifndef([AM_SILENT_RULES],
>> + [m4_define([AM_SILENT_RULES],[])])AM_SILENT_RULES([yes])
>>
> 
> Funny that only simple grep is used to identify these.

Newer automake has been taught to use more-reliable m4 tracing instead
of raw grep - but newer automake is the one that doesn't issue the
warning.  Yeah, I was rather shocked that this worked to shut up the
warning on RHEL 5 :)

> 
> ACK,

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]