[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 2/3] qemu: simplify list cleanup



On 09/04/2013 07:54 AM, Daniel P. Berrange wrote:
> On Wed, Aug 28, 2013 at 03:01:23PM -0600, Eric Blake wrote:
>> No need to open code now that we have a nice function.
>>
>> Interestingly, our virStringFreeList function is typed correctly
>> (a malloc'd list of malloc'd strings is NOT const, whether at the
>> point where it is created, or at the point where it is cleand up),

Oops, I'm just now noticing my typo (s/cleand/cleaned/), but we're stuck
with it...


> 
> ACK,
> 
> This duplicates part of my patch, but yours has a better commit
> message wrt these hunks, so please push this change & i'll rebase
> mine.

...due to the fact that you pushed on my behalf.  At any rate, thanks
for tackling this rather than waiting for me to finally get back to this
thread.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]