[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/3] qemu: don't leave shutdown inhibited on attach failure



On 09/04/2013 06:13 AM, Michal Privoznik wrote:
> On 29.08.2013 00:38, Eric Blake wrote:
>> While debugging a failure of 'virsh qemu-attach', I noticed that
>> we were leaking the count of active domains on failure.  This
>> means that a libvirtd session that is supposed to quit after
>> active domains disappear will hang around forever.
>>
>> * src/qemu/qemu_process.c (qemuProcessAttach): Undo count of
>> active domains on failure.
>>
>> Signed-off-by: Eric Blake <eblake redhat com>
>> ---
>>

>> @@ -4549,9 +4551,12 @@ int qemuProcessAttach(virConnectPtr conn ATTRIBUTE_UNUSED,
>>      return 0;
>>
>>  cleanup:
> 
> I don't like this label being 'cleanup' when in fact it should be
> 'error'. But that's pre-existing.

I fixed that.

> 
> ACK

and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]