[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH libvirt-python 05/17] Fix potential use of uninitialized value in virDomainGetVcpuPinInfo



On 09/09/2013 10:01 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The virDomainGetVcpuPinInfo python wrapper had a potential use of
> uninitialized values
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  libvirt-override.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This is an independent bug fix; should we apply it into libvirt.git now
(and rebase your submodule split accordingly), in case we don't feel
that the split is ready for use in time for 1.1.3?

> 
> diff --git a/libvirt-override.c b/libvirt-override.c
> index f4a36cf..46cdd2f 100644
> --- a/libvirt-override.c
> +++ b/libvirt-override.c
> @@ -1766,7 +1766,7 @@ libvirt_virDomainGetVcpuPinInfo(PyObject *self,
>      virDomainPtr domain;
>      PyObject *pyobj_domain, *pycpumaps = NULL;
>      virDomainInfo dominfo;
> -    unsigned char *cpumaps;
> +    unsigned char *cpumaps = NULL;
>      size_t cpumaplen, vcpu, pcpu;
>      unsigned int flags;
>      int i_retval, cpunum;
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]