[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Fix connectGetType() API



On Tue, Sep 10, 2013 at 03:06:29PM +0200, Michal Novotny wrote:
> This patch fixes qemuConnectGetType() API function to return KVM if
> appropriate, i.e. when /dev/kvm exists as the KVM module is loaded.
> No further check is being done so it's merely showing the possibility
> that KVM virtualization is available on the host however we don't
> have any guest information (as it's connection-only related) so we
> cannot sure we can use KVM. This can be useful to identify we have
> KVM (Virt Support) available on the host if host and guest archs
> are the same.

NACK, you are confusing two different things. virConnectGetType
is intended to return the libvirt driver name. This is *always*
'QEMU'.

If you want to know whether kvm virt is possible or not, then
query the capabilities XML.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]