[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 4/5] cpu_models: add the support for the test protocol



On Sat, Sep 07, 2013 at 01:11:25AM +0200, Giuseppe Scrivano wrote:
> Signed-off-by: Giuseppe Scrivano <gscrivan redhat com>
> ---
>  src/test/test_driver.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/src/test/test_driver.c b/src/test/test_driver.c
> index c225618..03d9c96 100644
> --- a/src/test/test_driver.c
> +++ b/src/test/test_driver.c
> @@ -5801,6 +5801,21 @@ testDomainScreenshot(virDomainPtr dom ATTRIBUTE_UNUSED,
>      return ret;
>  }
>  
> +static int
> +testConnectGetCPUModelNames(virConnectPtr conn ATTRIBUTE_UNUSED,
> +                            const char *arch ATTRIBUTE_UNUSED,
> +                            char ***models,
> +                            unsigned int flags)
> +{
> +    char **null_list;
> +
> +    virCheckFlags(0, -1);
> +    if (VIR_ALLOC_N(null_list, 1) < 0)
> +        return -1;
> +
> +    *models = null_list;
> +    return 0;
> +}

It'd be nice to have a non-NULL list for this IMHO.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]