[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 2/5] cpu_models: implement the remote protocol



On 09/06/2013 05:11 PM, Giuseppe Scrivano wrote:
> Signed-off-by: Giuseppe Scrivano <gscrivan redhat com>
> ---
>  daemon/remote.c              | 47 +++++++++++++++++++++++++++++++++++
>  src/remote/remote_driver.c   | 59 ++++++++++++++++++++++++++++++++++++++++++++
>  src/remote/remote_protocol.x | 20 ++++++++++++++-
>  src/remote_protocol-structs  | 11 +++++++++
>  4 files changed, 136 insertions(+), 1 deletion(-)

In addition to Dan's comments:

> +++ b/src/remote/remote_driver.c

> +error:
> +    rv = -1;
> +    for (i = 0; i < ret.models.models_len; i++)
> +        VIR_FREE(ret.models.models_val[i]);
> +    VIR_FREE(ret.models.models_val);

Another virStringFreeList()

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]