[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 4/5] cpu_models: add the support for the test protocol



"Daniel P. Berrange" <berrange redhat com> writes:

>> +static int
>> +testConnectGetCPUModelNames(virConnectPtr conn ATTRIBUTE_UNUSED,
>> +                            const char *arch ATTRIBUTE_UNUSED,
>> +                            char ***models,
>> +                            unsigned int flags)
>> +{
>> +    char **null_list;
>> +
>> +    virCheckFlags(0, -1);
>> +    if (VIR_ALLOC_N(null_list, 1) < 0)
>> +        return -1;
>> +
>> +    *models = null_list;
>> +    return 0;
>> +}
>
> It'd be nice to have a non-NULL list for this IMHO.

I'll use cpuGetModels here as well.  It shouldn't be a problem to use
the same data as the qemu driver.

Regards,
Giuseppe


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]