[libvirt] [PATCHv6 1/5] domifaddr: Implement the public APIs

Nehal J Wani nehaljw.kkd1 at gmail.com
Wed Sep 11 11:00:50 UTC 2013


ping


On Sun, Sep 8, 2013 at 2:42 PM, Osier Yang <jyang at redhat.com> wrote:

> [......]
>
>
>
>>>  + *
>>>> + * If 0 is passed as @flags, libvirt will choose the best way, and
>>>> won't
>>>> + * include agent in it.
>>>>
>>>
>>> I'm thinking if we don't need to be so complicated, by defaulting to one
>>> of _LEASE or _SNOOP explicitly.
>>>
>>> That says (conclusion of all of above), I'm wondering if define the enum
>>> like
>>> blow is better.
>>>
>>>
>>> typedef enum {
>>>     VIR_DOMAIN_INTERFACE_**ADDRESSES_AGENT = (1 << 1), /* Query qemu
>>> guest agent */
>>>
>>
>>
> And s/AGENT/GUEST_AGENT/, since "AGENT" could mean too much than "guest
> agent"
>
>
>


-- 
Nehal J Wani
UG3, BTech CS+MS(CL)
IIIT-Hyderabad
http://commandlinewani.blogspot.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130911/481a8dcd/attachment-0001.htm>


More information about the libvir-list mailing list