[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 RESEND] Add forwarders attribute to <dns /> element.



On 09/11/2013 03:36 PM, Laine Stump wrote:
> On 09/10/2013 04:26 PM, Diego Woitasen wrote:
>> Useful to set custom forwarders instead of using the contents of
>> /etc/resolv.conf. It helps me to setup dnsmasq as local nameserver to resolv VM
>> domain names from domain 0, when domain option is used.
> 
> 
> Dang! I had promised to look at this last week, then forgot :-(
> 
> 
>>
>>          &lt;domain name="example.com"/&gt;
>>          &lt;dns&gt;
>>            &lt;txt name="example" value="example value" /&gt;
>> +          &lt;forwarders addr="8.8.8.8" /&gt;
                                         --^
Please remove this space as well, to be consistent with the other elements.

Jan

>> +          &lt;forwarders addr="8.8.4.4" /&gt;
> 
> 
> In your earlier proposal, you had called this element "forward" rather
> than "forwards". I think a singular name is better, since each element
> is a single forwarding address.
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]