[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] tests: Don't test user config file if ran as root



On Thu, Sep 12, 2013 at 01:28:45PM +0200, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---
>  tests/virsh-uriprecedence | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/virsh-uriprecedence b/tests/virsh-uriprecedence
> index f4d84a4..aa90efe 100755
> --- a/tests/virsh-uriprecedence
> +++ b/tests/virsh-uriprecedence
> @@ -56,7 +56,11 @@ bad_uri="test:///default?bad_uri"
>  good_uri="test:///default?good_uri"
> 
>  printf "uri_default=\"%s\"\n" "$good_uri" >"$XDG_CONFIG_HOME/libvirt/libvirt.conf"
> -test_uri "User config file"
> +if uid_is_privileged_; then
> +    test_skip_case "$counter" "User config file" "must be run as root"


Should that say 'must not be run as root'  ?
                      ^^^

> +else
> +    test_uri "User config file"
> +fi
> 
>  printf "uri_default=\"%s\"\n" "$bad_uri" >"$XDG_CONFIG_HOME/libvirt/libvirt.conf"
>  export LIBVIRT_DEFAULT_URI="$good_uri"

ACK if you can answer the question either way.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]