[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix naming of permission for detecting storage pools



On 09/12/2013 07:37 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The VIR_ACCESS_PERM_CONNECT_DETECT_STORAGE_POOLS enum
> constant had its string format be 'detect_storage_pool',
> note the missing trailing 's'. This prevent the ACL
> check from ever succeeding. Fix this and add a simple
> test script to validate this problem of matching names.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/Makefile.am            |  8 ++++-
>  src/access/viraccessperm.c |  2 +-
>  src/check-aclperms.pl      | 75 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 83 insertions(+), 2 deletions(-)
>  create mode 100755 src/check-aclperms.pl
> 

>  
>  check-local: check-protocol check-symfile check-symsorting \
> -	check-drivername check-driverimpls check-aclrules
> +	check-drivername check-driverimpls check-aclrules \
> +        check-aclperms

TAB vs. space (probably TAB for consistency with the majority of the
makefile, even though this particular line is one of the rare places
where make accepts either spelling of indentation equally)

> +#
> +# This script just validates that the stringified version of
> +# a virAccessPerm enum matches the enum constant name. We do
> +# alot of auto-generation of code, so when these don't match

a/alot/a lot/

ACK with those fixes.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]