[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] netcf driver: use a single netcf handle for all connections



On 09/11/2013 11:58 AM, Daniel P. Berrange wrote:
> On Wed, Sep 11, 2013 at 11:06:26AM -0400, Laine Stump wrote:
>> +static void
>> +interfaceDriverLock(virNetcfDriverStatePtr driver)
>> +{
>> +    virObjectLock(driver);
>> +}
>> +
>> +static void
>> +interfaceDriverUnlock(virNetcfDriverStatePtr driver)
>> +{
>> +    virObjectUnlock(driver);
>> +}
> For everything else we converted to virObjectLockable, we have
> killed the lock/unlock wrappers and just called virObjectLock/Unlock
> directly. I think it is preferrable todo that here too. 

Yeah, those functions are kind of pointless now :-). Based on the ACK
from Doug, I squashed in a global replace of
interfaceDriver(Lock|Unlock) with virObject(Lock|Unlock), removed the
old lock functions, and pushed the result (after another round of tests,
of course)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]