[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] util: Declare that virFileExists shall honor errno



On 09/13/2013 08:19 AM, Peter Krempa wrote:
> Explicitly state that some parts of the code may require virFileExists
> to set or preserve a correct errno so that future modifications don't
> break.
> ---
>  src/util/virfile.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/util/virfile.c b/src/util/virfile.c
> index feac3c9..67adc55 100644
> --- a/src/util/virfile.c
> +++ b/src/util/virfile.c
> @@ -1477,6 +1477,12 @@ virFileIsDir(const char *path)
>      return (stat(path, &s) == 0) && S_ISDIR(s.st_mode);
>  }
> 
> +/**
> + * virFileExists: Check for presence of file
> + * @path: Path of file to check
> + *
> + * Returns wether file exists. Preserves errno in case it does not exist.

s/wether/whether/

or even:

s/wether/true if the/

> + */
>  bool
>  virFileExists(const char *path)
>  {
> 

ACK once you avoid the typo.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]