[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] build: make autobuild require rpm build deps



I spent far too long on a new machine trying to figure out why
./autobuild.sh failed during the rpm build failure (complaining
that libvirt_parthelper was supposed to be packaged but was not
built), and finally traced it to a missing parted-devel
installation.  I don't know why we have --nodeps in place, but
removing it would make rpmbuild error out much sooner, and with
a much less cryptic failure case.

* autobuild.sh: Drop --nodeps from rpmbuild lines.

Signed-off-by: Eric Blake <eblake redhat com>
---

I'm okay ditching this patch if someone can explain why the
--nodeps line should be there.

 autobuild.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/autobuild.sh b/autobuild.sh
index e5aa35c..0ab5f5e 100755
--- a/autobuild.sh
+++ b/autobuild.sh
@@ -60,7 +60,7 @@ else
 fi

 if test -f /usr/bin/rpmbuild ; then
-  rpmbuild --nodeps \
+  rpmbuild \
      --define "extra_release $EXTRA_RELEASE" \
      --define "_sourcedir `pwd`" \
      -ba --clean libvirt.spec
@@ -111,7 +111,7 @@ fi

 if test -x /usr/bin/i686-w64-mingw32-gcc && test -x /usr/bin/x86_64-w64-mingw32-gcc ; then
   if test -f /usr/bin/rpmbuild ; then
-    rpmbuild --nodeps \
+    rpmbuild \
        --define "extra_release $EXTRA_RELEASE" \
        --define "_sourcedir `pwd`" \
        -ba --clean mingw-libvirt.spec
-- 
1.8.3.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]