[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH RESEND 0/4] Pre-create storage on live migration



On Fri, Sep 13, 2013 at 1:31 AM, Michal Privoznik <mprivozn redhat com> wrote:
> [Resending due to some list difficulties]
>
> Currently users are required to pre-create storage on their own upon migration.
> This patch set implements the feature for RAW, QCOW and QCOW2 images. While for
> the RAW fallocate() is used (so we are guaranteed subsequent write() won't fail
> with ENOSPC, for the latter two we have no other option than using qemu-img,
> which uses ftruncate(). On the other hand, this is not such big deal. If the
> spare runs out as a domain is migrating, the migration is aborted, and
> pre-created storage unlink()-ed. There's no difference to what will happen if
> user will pre-create storage by hand.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=927252
>
>
> Michal Privoznik (4):
>   qemu: Expose file opening functions
>   qemu_domain: Introduce qemuDomainGetDiskBlockInfo
>   qemu_migration: Check size prerequisites
>   qemu_migration: Unlink pre-created storage on error
>
>  src/qemu/qemu_domain.c    | 299 ++++++++++++++++++++++++++++++++++++++++++++-
>  src/qemu/qemu_domain.h    |  16 +++
>  src/qemu/qemu_driver.c    | 276 ++---------------------------------------
>  src/qemu/qemu_migration.c | 304 +++++++++++++++++++++++++++++++++++++++++++++-
>  src/qemu/qemu_process.c   |   8 ++
>  5 files changed, 627 insertions(+), 276 deletions(-)
>
> --
> 1.8.1.5

I had a few comments on some of the patches. I mixed and matched
between the original and resend since I didn't see a full set of
either, so sorry about that. I didn't actually give this patchset a
whirl but I plan on it. I'm at LinuxCon this week so I'm not sure when
I'll have a chance.

-- 
Doug Goldstein


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]