[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] build: make autobuild require rpm build deps



On 09/16/2013 09:56 AM, Daniel P. Berrange wrote:
> On Mon, Sep 16, 2013 at 09:40:32AM -0600, Eric Blake wrote:
>> I spent far too long on a new machine trying to figure out why
>> ./autobuild.sh failed due to an rpm build failure (complaining
>> that libvirt_parthelper was supposed to be packaged but was not
>> built), and finally traced it to a missing parted-devel
>> installation.  I learned that --nodeps is in place for
>> autobuilder setups, but for developers, removing it would make
>> rpmbuild error out much sooner for a less cryptic failure.
>>
>> * autobuild.sh: Conditionally drop --nodeps from rpmbuild lines.
>>
>> Signed-off-by: Eric Blake <eblake redhat com>
>> ---
>>
>> v2: make --nodeps conditional based on $AUTOBUILD_COUNTER; suggested
>> by Dan Berrange.
>>

> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]