[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv4 4/4] VMX: Add a VMWare Fusion 5 configuration for tests



On 09/09/2013 07:48 PM, Doug Goldstein wrote:
> A user was having an issue with this specific VMWare Fusion config and
> he gave me permission to add it as part of our test suite to further
> expand our VMX test coverage. Unfortunately our VMX parser and
> generator does not support many features contained within and just
> silently ignores fields it does not understand so they had to
> be removed out in the xml2vmx test. The original unmodified version
> exists in the vmx2xml test.
> ---
>  tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.vmx | 88 ++++++++++++++++++++++
>  tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.xml | 39 ++++++++++
>  tests/vmx2xmltest.c                                |  2 +
>  tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.vmx | 30 ++++++++
>  tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.xml | 41 ++++++++++
>  tests/xml2vmxtest.c                                |  2 +
>  6 files changed, 202 insertions(+)
>  create mode 100644 tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.vmx
>  create mode 100644 tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.xml
>  create mode 100644 tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.vmx
>  create mode 100644 tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.xml

ACK.  More coverage never hurts :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]