[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/14] virsh-domain: Line up signal names array



On 09/10/2013 04:15 AM, Peter Krempa wrote:
> Line up the array so that the grid is visible.
> ---
> 
> Notes:
>     Not an useful change but it tripped my OCD while looking at the file.
> 
>  tools/virsh-domain.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
> index f6bfad0..727a42a 100644
> --- a/tools/virsh-domain.c
> +++ b/tools/virsh-domain.c
> @@ -7009,19 +7009,19 @@ static const vshCmdOptDef opts_send_process_signal[] = {
>  VIR_ENUM_DECL(virDomainProcessSignal)
>  VIR_ENUM_IMPL(virDomainProcessSignal,
>                VIR_DOMAIN_PROCESS_SIGNAL_LAST,
> -              "nop", "hup", "int", "quit", "ill", /* 0-4 */
> -              "trap", "abrt", "bus", "fpe", "kill", /* 5-9 */
> -              "usr1", "segv", "usr2", "pipe", "alrm", /* 10-14 */
> -              "term", "stkflt", "chld", "cont", "stop", /* 15-19 */
> -              "tstp", "ttin", "ttou", "urg", "xcpu", /* 20-24 */
> +              "nop",  "hup",    "int",  "quit",  "ill",  /* 0-4 */

As long as you're lining it up...
How about even spacing between columns, rather than minimal spacing for
the widest entry in a given column:

              "nop",    "hup",    "int",    "quit",   "ill",   /* 0-4 */

At any rate, it's no impact to the code, so ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]