[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 08/14] virsh-domain: Add command to allow modifications of XML metadata



On 09/10/2013 04:15 AM, Peter Krempa wrote:
> The metadata modification functions will support modification of the XML
> metadata. Add a virsh command to allow using this approach.
> ---
>  tools/virsh-domain.c | 161 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 161 insertions(+)
> 
> +    {.name = "desc",
> +     .data = N_("Allows to show or modify the XML metadata of a domain.")

Sounds awkward; maybe:
Shows or modifies the XML metadata of a domain.

> +    {.name = "key",
> +     .type = VSH_OT_DATA,
> +     .help = N_("key to be used as a namespace identificatior"),

s/identificatior/identifier/

> +    {.name = "metadata",
> +     .handler = cmdMetadata,
> +     .opts = opts_metadata,
> +     .info = info_metadata,
> +     .flags = 0

Not your fault, but we ought to be using trailing commas in C99 struct
initializers.

ACK with the grammar fixes.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]