[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh-domain: Remove unnecessary check and tune code in cmdDesc()



I understand. Thanks for your reminding.


2013/9/17 Ján Tomko <jtomko redhat com>
On 09/17/2013 11:16 AM, Hongwei Bi wrote:
> Since there is a check on buf through virBufferError(),
> it is not necessary to check desc again.

The buffer is used for the description provided on the virsh command line:
$ virsh desc <domain> Description

If you don't provide the description:

$ virsh desc --edit <domain>

then 'desc' is NULL and we need to fetch the existing domain description and
let the user edit it. Your patch removes this functionality.

Jan



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]