[libvirt] [PATCH] virsh-domain: Remove unnecessary check and tune code in cmdDesc()

Hongwei Bi hwbi2008 at gmail.com
Wed Sep 18 01:00:07 UTC 2013


I understand. Thanks for your reminding.



2013/9/17 Ján Tomko <jtomko at redhat.com>

> On 09/17/2013 11:16 AM, Hongwei Bi wrote:
> > Since there is a check on buf through virBufferError(),
> > it is not necessary to check desc again.
>
> The buffer is used for the description provided on the virsh command line:
> $ virsh desc <domain> Description
>
> If you don't provide the description:
>
> $ virsh desc --edit <domain>
>
> then 'desc' is NULL and we need to fetch the existing domain description
> and
> let the user edit it. Your patch removes this functionality.
>
> Jan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130918/04adfb6c/attachment-0001.htm>


More information about the libvir-list mailing list