[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] Add sample output of Wireshark dissector



2013/9/18 Daniel P. Berrange <berrange redhat com>:
> On Wed, Sep 18, 2013 at 09:16:07AM +0200, Peter Krempa wrote:
>> On 09/18/13 06:18, Yuto KAWAMURA(kawamuray) wrote:
>> > From: "Yuto KAWAMURA(kawamuray)" <kawamuray dadada gmail com>
>> >
>> > Add directory devtools/wireshark-dissector/samples/ and
>> > libvirt-sample.pdml which is sample output of dissector.
>> > ---
>> >  .../samples/libvirt-sample.pdml                    | 7970 ++++++++++++++++++++
>> >  1 file changed, 7970 insertions(+)
>> >  create mode 100644 devtools/wireshark-dissector/samples/libvirt-sample.pdml
>>
>> Is it really necessary to add a 800+ KiB file to the repository?
>
> Agreed, given its size I don't think we want this example file
> in the repo.
>
> ....it shouldn't even have been approved on the mailing lists !

Right. I will minimize sample pdml in next patch.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]