[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] Exclude files in VC_LIST_ALWAYS_EXCLUDE_REGEX from bracket-spacing-check



2013/9/18 Michal Privoznik <mprivozn redhat com>:
> On 18.09.2013 06:18, Yuto KAWAMURA(kawamuray) wrote:
>> From: "Yuto KAWAMURA(kawamuray)" <kawamuray dadada gmail com>
>>
>> Files specified in VC_LIST_ALWAYS_EXCLUDE_REGEX should excluded from
>> bracket-spacing-check too.
>> ---
>>  cfg.mk | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/cfg.mk b/cfg.mk
>> index e6584e8..3a31815 100644
>> --- a/cfg.mk
>> +++ b/cfg.mk
>> @@ -899,7 +899,7 @@ _autogen:
>>  syntax-check: $(top_srcdir)/HACKING bracket-spacing-check
>>
>>  bracket-spacing-check:
>> -     $(AM_V_GEN)files=`$(VC_LIST) | grep '\.c$$'`; \
>> +     $(AM_V_GEN)files=`$(VC_LIST) | grep '\.c$$' | grep -Ev -e '$(VC_LIST_ALWAYS_EXCLUDE_REGEX)'`; \
>>       $(PERL) $(top_srcdir)/build-aux/bracket-spacing.pl $$files || \
>>         { echo '$(ME): incorrect whitespace, see HACKING for rules' 1>&2; \
>>           exit 1; }
>>
>
> This shouldn't be needed. All the files in $VC_LIST_ALWAYS_EXCLUDE_REGEX
> should be excluded automatically. If not, then gnulib's broken.

I don't believe that files in VC_LIST_ALWAYS_EXCLUDE_REGEX is excluded
from bracket-spacing-check.
bracket-spacing-check checks files in VC_LIST and VC_LIST is not
applied any exclude filter.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]