[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 0/3] VMware: Driver updates for future work



While some of these patches seem unncessary (e.g. vmrun lookup/caching)
my end goal is to add VMware Fusion support to libvirt.

Rationale for patch 1: In libvirt we prefer enums and using some of the
standardized APIs for enum/str handling.

Rationale for patch 2: VMware Fusion command line utilities will never be
in PATH on a Mac OS X machine and nor is it correct to tell the user to
have it in your path. The tools live in /Applications/VMware Fusion.app/
or /Library/Application Support/VMware Fusion.app/ and app bundles should
not appear in your path. In the future it will allow us to add these
pathes in the list of paths to search for. We can also improve the Windows
user experience and populate the Windows path in here as well since
most users don't have the VMware install dir in their PATH.

Rationale for patch 3: Testing is good. VMware Fusion has a slightly
different string format for the version so the code will need to change
this allows us to add tests.

I personally don't own a copy of VMware Workstation or VMware Fusion,
so if anyone does please send me (or submit patches) of additional
version numbers so that we can improve our test coverage.

Doug Goldstein (3):
  VMware: Convert driver type defines to enum
  VMware: Store vmrun binary's path in the driver
  VMware: Make version parsing testable and add tests

 .gitignore                                |   1 +
 src/Makefile.am                           |   6 ++
 src/libvirt_vmware.syms                   |  12 ++++
 src/vmware/vmware_conf.c                  |  61 ++++++++++++-----
 src/vmware/vmware_conf.h                  |  15 ++++-
 src/vmware/vmware_driver.c                |  63 +++++++++++-------
 tests/Makefile.am                         |  14 ++++
 tests/vmwareverdata/workstation-7.0.0.txt |   1 +
 tests/vmwarevertest.c                     | 105 ++++++++++++++++++++++++++++++
 9 files changed, 233 insertions(+), 45 deletions(-)
 create mode 100644 src/libvirt_vmware.syms
 create mode 100644 tests/vmwareverdata/workstation-7.0.0.txt
 create mode 100644 tests/vmwarevertest.c

-- 
1.8.1.5


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]