[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/3] VMware: Make version parsing testable and add tests



On Thu, Sep 19, 2013 at 03:18:07PM -0500, Doug Goldstein wrote:
> This splits up the version parsing code into a callable API like QEMU
> help/version string parsing so that we can test it as we need to add
> additional patterns for newer versions/products.
> ---
>  .gitignore                                |   1 +
>  src/Makefile.am                           |   6 ++
>  src/libvirt_vmware.syms                   |  12 ++++
>  src/vmware/vmware_conf.c                  |  49 ++++++++++----
>  src/vmware/vmware_conf.h                  |   2 +
>  tests/Makefile.am                         |  14 ++++
>  tests/vmwareverdata/workstation-7.0.0.txt |   1 +
>  tests/vmwarevertest.c                     | 105 ++++++++++++++++++++++++++++++
>  8 files changed, 176 insertions(+), 14 deletions(-)
>  create mode 100644 src/libvirt_vmware.syms
>  create mode 100644 tests/vmwareverdata/workstation-7.0.0.txt
>  create mode 100644 tests/vmwarevertest.c

ACK


Danielx
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]