[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] qemu: Add SPAPR_VFIO_BRIDGE capability for PPC platform



On 09/16/2013 03:42 AM, Li Zhang wrote:
> From: Li Zhang <zhlcindy linux vnet ibm com>
>
> To support VFIO for PPC, it is needed spapr-vfio-pci-host-bridge in
> QEMU. This patch is to add one capability for it.
>
> Signed-off-by: Li Zhang <zhlcindy linux vnet ibm com>
> ---
>  src/qemu/qemu_capabilities.c | 2 ++
>  src/qemu/qemu_capabilities.h | 1 +
>  2 files changed, 3 insertions(+)
>
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index d94188a..7cc02db 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -241,6 +241,7 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST,
>                "usb-storage", /* 155 */
>                "usb-storage.removable",
>                "virtio-mmio",
> +              "spapr-pci-vfio-host-bridge",

Having no access to the appropriate hardware, I can't verify if this is
the correct name for the device or not, but will assume it is.

ACK for what you have, but this only detects the capability and exposes
it to the commandline generator - it's better to not push something that
changes the ABI (the list of capabilities are included when
saving/migrating) without also having a patch that demonstrates its
utility (and that patch should also add a test case to qemuxml2argvtest)

>      );
>  
>  struct _virQEMUCaps {
> @@ -1391,6 +1392,7 @@ struct virQEMUCapsStringFlags virQEMUCapsObjectTypes[] = {
>      { "i82801b11-bridge", QEMU_CAPS_DEVICE_DMI_TO_PCI_BRIDGE },
>      { "usb-storage", QEMU_CAPS_DEVICE_USB_STORAGE },
>      { "virtio-mmio", QEMU_CAPS_DEVICE_VIRTIO_MMIO },
> +    { "spapr-pci-vfio-host-bridge", QEMU_CAPS_SPAPR_VFIO_BRIDGE },
>  };
>  
>  static struct virQEMUCapsStringFlags virQEMUCapsObjectPropsVirtioBlk[] = {
> diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
> index f3c8fa8..33d303e 100644
> --- a/src/qemu/qemu_capabilities.h
> +++ b/src/qemu/qemu_capabilities.h
> @@ -196,6 +196,7 @@ enum virQEMUCapsFlags {
>      QEMU_CAPS_DEVICE_USB_STORAGE = 155, /* -device usb-storage */
>      QEMU_CAPS_USB_STORAGE_REMOVABLE = 156, /* usb-storage.removable */
>      QEMU_CAPS_DEVICE_VIRTIO_MMIO = 157, /* -device virtio-mmio */
> +    QEMU_CAPS_SPAPR_VFIO_BRIDGE   = 158, /* -device spapr-pci-vfio-host-bridge */
>  
>      QEMU_CAPS_LAST,                   /* this must always be the last item */
>  };



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]