[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 05/10] Fix crash on OOM in qemuAddRBDHost



On 09/23/13 15:23, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> When parsing the RBD hosts, it increments the 'nhosts' counter
> before increasing the 'hosts' array allocation. If an OOM then
> occurs when increasing the array allocation, the cleanup block
> will attempt to access beyond the end of the array. Switch
> to using VIR_EXPAND_N instead of VIR_REALLOC_N to protect against
> this mistake
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/qemu/qemu_command.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

ACK.

Peter


Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]