[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 06/10] Fix allocation of arglist in qemuStringToArgvEnv



On 09/23/13 15:23, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> In
> 
>   commit 41b550567918790cb304378f39c3ba369bcca28e
>   Author: Eric Blake <eblake redhat com>
>   Date:   Wed Aug 28 15:01:23 2013 -0600
> 
>     qemu: simplify list cleanup
> 
> The qemuStringToArgvEnv method was changed to use virStringFreeList
> to free the 'arglist' array. This method assumes the string list
> array is NULL terminated, however, qemuStringToArgvEnv was not
> ensuring this when populating 'arglist'. This caused an out of
> bounds access by virStringFreeList when OOM occured in the initial
> loop of qemuStringToArgvEnv
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/qemu/qemu_command.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)

ACK,

Peter



Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]