[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 22/23] Avoid crash on OOM in virnetmessagetest



From: "Daniel P. Berrange" <berrange redhat com>

The virnetmessagetest code did not check for failure to
allocate the message object. This lead to a crash on OOM
in the test suite.

Signed-off-by: Daniel P. Berrange <berrange redhat com>
---
 tests/virnetmessagetest.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/virnetmessagetest.c b/tests/virnetmessagetest.c
index 1aa4c25..3c9bead 100644
--- a/tests/virnetmessagetest.c
+++ b/tests/virnetmessagetest.c
@@ -327,6 +327,9 @@ static int testMessagePayloadDecode(const void *args ATTRIBUTE_UNUSED)
     };
     int ret = -1;
 
+    if (!msg)
+        return -1;
+
     msg->bufferLength = 4;
     if (VIR_ALLOC_N(msg->buffer, msg->bufferLength) < 0)
         goto cleanup;
@@ -476,6 +479,9 @@ static int testMessagePayloadStreamEncode(const void *args ATTRIBUTE_UNUSED)
     };
     int ret = -1;
 
+    if (!msg)
+        return -1;
+
     msg->header.prog = 0x11223344;
     msg->header.vers = 0x01;
     msg->header.proc = 0x666;
-- 
1.8.3.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]